feat: add opentelemetry middleware to web server#79
feat: add opentelemetry middleware to web server#79DCchoudhury15 wants to merge 6 commits intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 50.95% 51.07% +0.12%
==========================================
Files 87 88 +1
Lines 4814 4826 +12
==========================================
+ Hits 2453 2465 +12
- Misses 2149 2151 +2
+ Partials 212 210 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @furykerry pr up for review |
|
@AiRanthem up for review |
|
@DCchoudhury15 the patch seems incomplete, no one will call NewServer |
6af8800 to
086d3b4
Compare
|
@furykerry implemented the fix up for review |
|
@DCchoudhury15: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR integrates OpenTelemetry (OTEL) middleware into the Gin web server to enable tracing and observability, as requested in #23.
Which issue(s) this PR fixes:
Fixes #23
Special notes for your reviewer:
otelginmiddleware to the Gin router inpkg/servers/web/server.go.NewServerto accept aServiceinterface instead of the concretee2bimplementation. This was necessary to resolve a circular dependency between thewebande2bpackages.go.modto includego.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin.