generate istio destinationRule subset from pod-template-hash #212
Open
myname4423 wants to merge 3 commits intoopenkruise:masterfrom
Open
generate istio destinationRule subset from pod-template-hash #212myname4423 wants to merge 3 commits intoopenkruise:masterfrom
myname4423 wants to merge 3 commits intoopenkruise:masterfrom
Conversation
…ields to allow user set canary/stable subset name Signed-off-by: yunbo <yunbo10124scut@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: yunbo <yunbo10124scut@gmail.com>
|
@myname4423: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and add fields to allow user set canary/stable subset name
Ⅰ. Describe what this PR does
Behaviors if this PR merged:
when work with Istio for trafficRouting, if
spec.strategy.canary.disableGenerateCanaryServiceis settrueand Istio DestinationRule is provided, Rollout will append a canary subset for DestinationRule. The stable subset(if not provided in DestinationRule, stable subset will be create also) and canary subset are distinguished by label selectors, which are respectively pod-template-hash of v1 and v2.User is allowed to set subset name of stable subset and canary subset, via
spec.strategy.canary.trafficRoutings[x].additionalParams, such asⅡ. Does this pull request fix one issue?
no
Ⅲ. Special notes for reviews
will update doc later