Fix order of object in batchrelease event handler#265
Fix order of object in batchrelease event handler#265furykerry merged 1 commit intoopenkruise:masterfrom
Conversation
|
Welcome @z760087139! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 45.55% 45.22% -0.33%
==========================================
Files 57 61 +4
Lines 6395 7073 +678
==========================================
+ Hits 2913 3199 +286
- Misses 2989 3324 +335
- Partials 493 550 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@z760087139 can you sign your commit to pass the DCO checking? |
Signed-off-by: z760087139 <z760087139@gmail.com>
Thanks for the reminder! I've signed off my commit and force-pushed the changes. The commit now included |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: z760087139 <z760087139@gmail.com>
Ⅰ. Describe what this PR does
Possible Variable Naming Issue in Update Event Handler
Ⅱ. Does this pull request fix one issue?
fixes #264
Ⅲ. Special notes for reviews