Skip to content

Fix order of object in batchrelease event handler#265

Merged
furykerry merged 1 commit intoopenkruise:masterfrom
z760087139:fix264
Apr 10, 2025
Merged

Fix order of object in batchrelease event handler#265
furykerry merged 1 commit intoopenkruise:masterfrom
z760087139:fix264

Conversation

@z760087139
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

Possible Variable Naming Issue in Update Event Handler

Ⅱ. Does this pull request fix one issue?

fixes #264

Ⅲ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and furykerry April 9, 2025 07:07
@kruise-bot
Copy link
Copy Markdown

Welcome @z760087139! It looks like this is your first PR to openkruise/rollouts 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.22%. Comparing base (056c77d) to head (03e472d).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   45.55%   45.22%   -0.33%     
==========================================
  Files          57       61       +4     
  Lines        6395     7073     +678     
==========================================
+ Hits         2913     3199     +286     
- Misses       2989     3324     +335     
- Partials      493      550      +57     
Flag Coverage Δ
unittests 45.22% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@AiRanthem AiRanthem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think it is a naming issue

@furykerry
Copy link
Copy Markdown
Member

@z760087139 can you sign your commit to pass the DCO checking?

Signed-off-by: z760087139 <z760087139@gmail.com>
@z760087139
Copy link
Copy Markdown
Contributor Author

@z760087139 can you sign your commit to pass the DCO checking?

Thanks for the reminder! I've signed off my commit and force-pushed the changes.

The commit now included

Copy link
Copy Markdown
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry furykerry merged commit 2aa692d into openkruise:master Apr 10, 2025
31 of 32 checks passed
zmberg pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: z760087139 <z760087139@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible Variable Naming Issue in Update Event Handler

4 participants