Feature: copy annotations and labels from the stable service to the canary service#301
Conversation
…vice Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 47.51% 47.52% +0.01%
==========================================
Files 63 63
Lines 9797 9799 +2
==========================================
+ Hits 4655 4657 +2
Misses 4585 4585
Partials 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/trafficrouting/manager.go
Outdated
| } | ||
|
|
||
| func (m *Manager) createCanaryService(c *TrafficRoutingContext, cService string, spec corev1.ServiceSpec) (*corev1.Service, error) { | ||
| func (m *Manager) createCanaryService(c *TrafficRoutingContext, cService string, spec corev1.ServiceSpec, annotations, labels map[string]string) (*corev1.Service, error) { |
There was a problem hiding this comment.
if we have to copy the metadata, then just pass the service object instead of servicespec
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews