Skip to content

Fix the issue where the BatchRelease gets stuck in Verifying when the Deployment's PodTemplate already contains pod-template-hash label#307

Merged
kruise-bot merged 2 commits intoopenkruise:masterfrom
AiRanthem:fix/deployment-templatehash-250904
Sep 28, 2025
Merged

Fix the issue where the BatchRelease gets stuck in Verifying when the Deployment's PodTemplate already contains pod-template-hash label#307
kruise-bot merged 2 commits intoopenkruise:masterfrom
AiRanthem:fix/deployment-templatehash-250904

Conversation

@AiRanthem
Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

… Deployment's PodTemplate already contains pod-template-hash label

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.58%. Comparing base (00aae12) to head (0713c6a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/batchrelease/labelpatch/patcher.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   47.52%   47.58%   +0.06%     
==========================================
  Files          63       63              
  Lines        9799     9811      +12     
==========================================
+ Hits         4657     4669      +12     
  Misses       4585     4585              
  Partials      557      557              
Flag Coverage Δ
unittests 47.58% <93.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Copy link
Copy Markdown
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AiRanthem
Copy link
Copy Markdown
Member Author

fixes #308

@AiRanthem AiRanthem assigned AiRanthem and unassigned furykerry Sep 5, 2025
@zmberg
Copy link
Copy Markdown
Member

zmberg commented Sep 28, 2025

/approve

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 7efc811 into openkruise:master Sep 28, 2025
34 checks passed
zmberg pushed a commit that referenced this pull request Nov 25, 2025
… Deployment's PodTemplate already contains pod-template-hash label (#307)

* Fix the issue where the BatchRelease gets stuck in Verifying when the Deployment's PodTemplate already contains pod-template-hash label

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>

* Add some comments

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>

---------

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants