Do your best to clean up the upgrade state when finish, otherwise, it may affect the next upgrade.#331
Do your best to clean up the upgrade state when finish, otherwise, it may affect the next upgrade.#331gaopeiliang wants to merge 1 commit intoopenkruise:masterfrom
Conversation
otherwise, it may affect the next upgrade.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @gaopeiliang! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 51.38% 51.38%
=======================================
Files 66 66
Lines 8559 8559
=======================================
Hits 4398 4398
Misses 3575 3575
Partials 586 586
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
#330
when use karmada sync deployment ; batch release controller should clear up rolling strategy when finish ;;
But it maybe ignore this because karmada sync always and webhook not hook "spec.paused" field;; it will affect next upgrade;
So the conditions for cleaning up the state after the upgrade should be more relaxed.