Reduce log file size - SMT is logging at DEBUG level#944
Reduce log file size - SMT is logging at DEBUG level#944Rajat-0 merged 1 commit intoopenmainframeproject:masterfrom
Conversation
P-V-SAI-SURAKSHA
force-pushed
the
smt_log_level
branch
2 times, most recently
from
81295a9 to
4cede19
Compare
Bischoff
left a comment
Bischoff
left a comment
There was a problem hiding this comment.
The code looks good to me, I tested it to work, but see my remark.
smtLayer/smt.py
Outdated
| log_level_str = "logging.WARN" | ||
| elif level in ("ERROR", "LOGGING.ERROR"): | ||
| log_level_str = "logging.ERROR" | ||
| elif level in ("CRITICAL", "LOGGING.CRITICAL"): |
There was a problem hiding this comment.
I know that file log.py contains as well:
elif log_level in ('LOGGING.CRITICAL', 'CRITICAL'):
log_level = logging.CRITICAL
but CRITICAL does not appear anywhere in the code, and is not even documented...
What about removing those 2 lines from log.py instead of adding them here?
There was a problem hiding this comment.
@Bischoff yes since "CRITICAL" is not used anywhere in the codebase and is not documented I’ve removed the CRITICAL handling from log.py .
There was a problem hiding this comment.
Thank you. I'm a big fan of YAGNI 😛
Signed-off-by: suraksha <p.v.sai.suraksha@ibm.com>
P-V-SAI-SURAKSHA
force-pushed
the
smt_log_level
branch
from
4cede19 to
e4522d8
Compare
Bischoff
left a comment
Bischoff
left a comment
There was a problem hiding this comment.
Thanks for the changes, approving.
|
@P-V-SAI-SURAKSHA I am not a "reviewer with write access", so you might need an approval from @mfriesenegger or @Rajat-0 for the automated tests to be green ;) . |
3 participants
Task Description:
Solution:
Updated smt.py to read the log level from the configuration file, defaulting to INFO when not set. Logging is now controlled by the configured level, reducing unnecessary log entries and preventing large log files.