Fix no serialization of periodic_surface_id bug#3421
Merged
paulromano merged 3 commits intoopenmc-dev:developfrom Jun 5, 2025
Merged
Fix no serialization of periodic_surface_id bug#3421paulromano merged 3 commits intoopenmc-dev:developfrom
paulromano merged 3 commits intoopenmc-dev:developfrom
Conversation
paulromano
approved these changes
Jun 4, 2025
Contributor
paulromano
left a comment
There was a problem hiding this comment.
Thanks @GuySten! I made a few minor updates on this PR and now it's good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, OpenMC does not (de)serialize periodic surface id data (from)to summary.h5 file.
This pull request add the relevant needed code.
Fixes #2850
Checklist