Skip to content

Fix no serialization of periodic_surface_id bug#3421

Merged
paulromano merged 3 commits intoopenmc-dev:developfrom
GuySten:serialize_periodic_surface_id
Jun 5, 2025
Merged

Fix no serialization of periodic_surface_id bug#3421
paulromano merged 3 commits intoopenmc-dev:developfrom
GuySten:serialize_periodic_surface_id

Conversation

@GuySten
Copy link
Copy Markdown
Contributor

@GuySten GuySten commented May 29, 2025

Description

Currently, OpenMC does not (de)serialize periodic surface id data (from)to summary.h5 file.
This pull request add the relevant needed code.

Fixes #2850

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Copy Markdown
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GuySten! I made a few minor updates on this PR and now it's good to go.

@paulromano paulromano enabled auto-merge (squash) June 4, 2025 21:49
@paulromano paulromano merged commit dadc4fe into openmc-dev:develop Jun 5, 2025
14 checks passed
@GuySten GuySten deleted the serialize_periodic_surface_id branch June 5, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

periodic_surface_id is lost when reading a statepoint to perform a restart simulation

2 participants