Implement depth-awareness when enforcing precedence between union/intersection operators#3730
Merged
pshriwise merged 3 commits intoopenmc-dev:developfrom Jan 16, 2026
Merged
Conversation
GuySten
approved these changes
Jan 15, 2026
Contributor
GuySten
left a comment
GuySten
left a comment
There was a problem hiding this comment.
Looks great to me!
Its also nice to have a rich test suite for the region parsing.
5 tasks
Contributor
|
Do you have any literature on these algorithms? This sounds like a bug I have been dealing with. |
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
…ersection operators (openmc-dev#3730) Co-authored-by: GuySten <guyste@post.bgu.ac.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an alternative to #3698 and is intended to solve the same problem but in a more rigorous way by ensuring that when we add parentheses in region expressions to enforce precedence between intersection and union operators, it is done in a manner that accounts for the depth at which the operators appear. With this fix, it is not necessary to convert to/from postfix as is done in #3698. I've added numerous test cases that demonstrate that it functions correctly.
Fixes #3685
Checklist
I have followed the style guidelines for Python source files (if applicable)