Skip to content

refactor: start implementing gathering invoice #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turip merged 11 commits into from
Feb 4, 2026
Merged

refactor: start implementing gathering invoice #3804

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bf54422
feat: implement gathering invoice
turip Jan 29, 2026
8b4bdee
fix: progress
turip Feb 3, 2026
1c3bb92
feat: progress
turip Feb 3, 2026
ba07cfb
fix: testcases
turip Feb 3, 2026
607e22e
feat: rename to UpcomingCharges
turip Feb 4, 2026
d45ce82
fix: naming
turip Feb 4, 2026
bd5756b
fix: collection at persisting
turip Feb 4, 2026
0c868dd
fix: review comments
turip Feb 4, 2026
c4bfde6
fix: more review
turip Feb 4, 2026
7aed383
fix: remove unused calculation
turip Feb 4, 2026
753bd64
fix: do not surface ent error
turip Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/spec/src/billing/invoices.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,7 @@ model InvoicePendingLineCreateResponse {
@visibility(Lifecycle.Read)
lines: InvoiceLine[];

// TODO: For the V3 api let's not return the invoice
/**
* The invoice containing the created lines.
*/
Expand Down
9 changes: 9 additions & 0 deletions openmeter/billing/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ type Adapter interface {
InvoiceLineAdapter
InvoiceSplitLineGroupAdapter
InvoiceAdapter
GatheringInvoiceAdapter
SequenceAdapter
InvoiceAppAdapter
CustomerSynchronizationAdapter
Expand Down Expand Up @@ -74,6 +75,14 @@ type InvoiceAdapter interface {
GetInvoiceOwnership(ctx context.Context, input GetInvoiceOwnershipAdapterInput) (GetOwnershipAdapterResponse, error)
}

type GatheringInvoiceAdapter interface {
CreateGatheringInvoice(ctx context.Context, input CreateGatheringInvoiceAdapterInput) (GatheringInvoice, error)
UpdateGatheringInvoice(ctx context.Context, input UpdateGatheringInvoiceAdapterInput) error
DeleteGatheringInvoice(ctx context.Context, input DeleteGatheringInvoiceAdapterInput) error
GetGatheringInvoiceById(ctx context.Context, input GetGatheringInvoiceByIdInput) (GatheringInvoice, error)
ListGatheringInvoices(ctx context.Context, input ListGatheringInvoicesInput) (pagination.Result[GatheringInvoice], error)
}

type InvoiceSplitLineGroupAdapter interface {
CreateSplitLineGroup(ctx context.Context, input CreateSplitLineGroupAdapterInput) (SplitLineGroup, error)
UpdateSplitLineGroup(ctx context.Context, input UpdateSplitLineGroupInput) (SplitLineGroup, error)
Expand Down
Loading
Loading