Skip to content

Sync ORelay from moxygen relay (21c3597..b426e6c6); add sync-relay.sh - #51

Merged
afrind merged 2 commits into
mainfrom
relay-sync
Mar 13, 2026
Merged

Sync ORelay from moxygen relay (21c3597..b426e6c6); add sync-relay.sh#51
afrind merged 2 commits into
mainfrom
relay-sync

Conversation

@afrind

@afrind afrind commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Brings ORelay up to date with 9 upstream moxygen commits:

  • NamespaceSubscriberInfo struct (forward, options, namespacePublishHandle, trackNamespacePrefix) replacing bare bool in sessions map
  • Draft 16+ bidi stream support in publishNamespace/publishNamespaceDone
  • trackStatus method (forward to upstream or answer from local forwarder)
  • publishToSession: remove PublishRequest param
  • subscribeNamespace: allow empty prefix for draft 16+; store full NamespaceSubscriberInfo; draft 16+ namespace message path
  • subscribe/publish: setExtensions replacing setGroupOrder/delivery timeout
  • Remove MoQTrackProperties.h include
  • 523 new test lines covering all new functionality

scripts/sync-relay.sh automates future syncs: copies MoQRelay.h/.cpp and MoQRelayTest.cpp from deps/moxygen, applies name/namespace transforms (MoQRelay→ORelay, namespace moxygen→openmoq::o_rly, moxygen:: qualifiers in header, using namespace moxygen in .cpp), formats, builds, and tests.


This change is Reviewable

@afrind
afrind requested a review from michalhosna March 12, 2026 01:22

@michalhosna michalhosna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalhosna reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on afrind).


-- commits line 21 at r1:
The script should have its own commit. If I understand it correctly, that script is not synced from upstream.

It will make the attribution (git blame) easier to track down in the history.


scripts/sync-relay.sh line 218 at r1 (raw file):

fi

echo "==> Done"

It looks fragile to me, but we will see over time.

@michalhosna michalhosna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalhosna made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on afrind).


scripts/sync-relay.sh line 218 at r1 (raw file):

Previously, michalhosna (Michal Hošna) wrote…

It looks fragile to me, but we will see over time.

EDIT: The script look fragile, to be clear

afrind added 2 commits March 12, 2026 20:16
Brings ORelay up to date with 9 upstream moxygen commits:
- NamespaceSubscriberInfo struct (forward, options, namespacePublishHandle,
  trackNamespacePrefix) replacing bare bool in sessions map
- Draft 16+ bidi stream support in publishNamespace/publishNamespaceDone
- trackStatus method (forward to upstream or answer from local forwarder)
- publishToSession: remove PublishRequest param
- subscribeNamespace: allow empty prefix for draft 16+; store full
  NamespaceSubscriberInfo; draft 16+ namespace message path
- subscribe/publish: setExtensions replacing setGroupOrder/delivery timeout
- Remove MoQTrackProperties.h include
- 523 new test lines covering all new functionality

@afrind afrind left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on michalhosna).


-- commits line 21 at r1:

Previously, michalhosna (Michal Hošna) wrote…

The script should have its own commit. If I understand it correctly, that script is not synced from upstream.

It will make the attribution (git blame) easier to track down in the history.

fixed


scripts/sync-relay.sh line 218 at r1 (raw file):

Previously, michalhosna (Michal Hošna) wrote…

EDIT: The script look fragile, to be clear

It's not intended for long term. We're going to diverge pretty soon.

@afrind afrind left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind resolved 2 discussions.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on afrind).

@afrind
afrind merged commit 19e6c1f into main Mar 13, 2026
5 of 6 checks passed
@afrind
afrind deleted the relay-sync branch March 13, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants