Sync ORelay from moxygen relay (21c3597..b426e6c6); add sync-relay.sh - #51
Conversation
michalhosna
left a comment
There was a problem hiding this comment.
@michalhosna reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on afrind).
-- commits line 21 at r1:
The script should have its own commit. If I understand it correctly, that script is not synced from upstream.
It will make the attribution (git blame) easier to track down in the history.
scripts/sync-relay.sh line 218 at r1 (raw file):
fi echo "==> Done"
It looks fragile to me, but we will see over time.
michalhosna
left a comment
There was a problem hiding this comment.
@michalhosna made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on afrind).
scripts/sync-relay.sh line 218 at r1 (raw file):
Previously, michalhosna (Michal Hošna) wrote…
It looks fragile to me, but we will see over time.
EDIT: The script look fragile, to be clear
Brings ORelay up to date with 9 upstream moxygen commits: - NamespaceSubscriberInfo struct (forward, options, namespacePublishHandle, trackNamespacePrefix) replacing bare bool in sessions map - Draft 16+ bidi stream support in publishNamespace/publishNamespaceDone - trackStatus method (forward to upstream or answer from local forwarder) - publishToSession: remove PublishRequest param - subscribeNamespace: allow empty prefix for draft 16+; store full NamespaceSubscriberInfo; draft 16+ namespace message path - subscribe/publish: setExtensions replacing setGroupOrder/delivery timeout - Remove MoQTrackProperties.h include - 523 new test lines covering all new functionality
afrind
left a comment
There was a problem hiding this comment.
@afrind made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on michalhosna).
Previously, michalhosna (Michal Hošna) wrote…
The script should have its own commit. If I understand it correctly, that script is not synced from upstream.
It will make the attribution (git blame) easier to track down in the history.
fixed
scripts/sync-relay.sh line 218 at r1 (raw file):
Previously, michalhosna (Michal Hošna) wrote…
EDIT: The script look fragile, to be clear
It's not intended for long term. We're going to diverge pretty soon.
afrind
left a comment
There was a problem hiding this comment.
@afrind resolved 2 discussions.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on afrind).
Brings ORelay up to date with 9 upstream moxygen commits:
scripts/sync-relay.sh automates future syncs: copies MoQRelay.h/.cpp and MoQRelayTest.cpp from deps/moxygen, applies name/namespace transforms (MoQRelay→ORelay, namespace moxygen→openmoq::o_rly, moxygen:: qualifiers in header, using namespace moxygen in .cpp), formats, builds, and tests.
This change is