tools: add per-scrape/averaging window control for histogram metrics - #520
Merged
Conversation
Histogram-derived metrics (evb loop busy, object ACK latency, client latency) now compute p99/p50/mean over the per-scrape counter delta by default, with a new "avg" dropdown to average over a 10s/30s/1m/5m span instead. histWindowStats() diffs against the previous scrape when the span is 0, else against the oldest snapshot within the span, and returns an empty stat on the first scrape when no delta exists yet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gmarzot
approved these changes
Jul 27, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
@gmarzot reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Histogram-derived metrics (evb loop busy, object ACK latency, client latency) now compute p99/p50/mean over the per-scrape counter delta by default, with a new "avg" dropdown to average over a 10s/30s/1m/5m span instead. histWindowStats() diffs against the previous scrape when the span is 0, else against the oldest snapshot within the span, and returns an empty stat on the first scrape when no delta exists yet.
This change is