scripts: add -j/--jobs and MOQX_BUILD_JOBS to control build parallelism - #523
Merged
Conversation
Both build.sh and setup-deps-standalone.sh hardcoded nproc for the cmake --build job count. distcc wants far more jobs than the local core count, so add an explicit override with precedence: -j flag, then MOQX_BUILD_JOBS, then nproc. Also loosen the optional-SHA lookahead in --from-release/--from-source from "$1" != --* to "$1" != -* so a following -j isn't consumed as a SHA. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gmarzot
approved these changes
Jul 27, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
@gmarzot reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on michalhosna).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both build.sh and setup-deps-standalone.sh hardcoded nproc for the cmake --build job count. distcc wants far more jobs than the local core count, so add an explicit override with precedence: -j flag, then MOQX_BUILD_JOBS, then nproc.
Also loosen the optional-SHA lookahead in --from-release/--from-source from "$1" != --* to "$1" != -* so a following -j isn't consumed as a SHA.
This change is