relay: fold registry replacement into installPublisherForwarder - #544
Merged
Merged
Conversation
akash-a-n
approved these changes
Aug 7, 2026
akash-a-n
left a comment
akash-a-n
left a comment
Contributor
There was a problem hiding this comment.
@akash-a-n reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind).
afrind
force-pushed
the
lf-install-publisher-forwarder
branch
from
August 11, 2026 15:37
2807fd1 to
f67ed45
Compare
Previously, createPublisherForwarder built a forwarder and returned it to the caller to register. Now, installPublisherForwarder takes an already-constructed forwarder, wires its callback chain, and returns the LocalForwarderRegistry::Claim from replacing the registry entry, so the subscribe path can use it in a subsequent commit. publishFromPublisherExec constructs the forwarder itself and calls markReady on that claim. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
afrind
force-pushed
the
lf-install-publisher-forwarder
branch
from
August 11, 2026 15:39
f67ed45 to
d194100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, createPublisherForwarder built a forwarder and returned it to the caller to register. Now, installPublisherForwarder takes an already-constructed forwarder, wires its callback chain, and returns the LocalForwarderRegistry::Claim from replacing the registry entry, so the subscribe path can use it in a subsequent commit. publishFromPublisherExec constructs the forwarder itself and calls markReady on that claim.
This change is