Improve build change detection - #55
Conversation
Track moxygen's full dependency manifest tree so changes to any upstream manifest trigger a full setup-deps.sh run. Use getdeps.py to derive the manifest list dynamically rather than maintaining it by hand. Add .build-rev stamps after each meta dep build and check them in meta_deps_installed() so that incomplete or interrupted installs trigger a rebuild on the next run. Write stamps in save_stamps() so initial setup via setup-deps.sh also produces them.
|
|
gmarzot
left a comment
There was a problem hiding this comment.
@gmarzot reviewed 2 files and all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on afrind).
afrind
left a comment
There was a problem hiding this comment.
@afrind made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on akash-a-n, gmarzot, and michalhosna).
Previously, gmarzot (Giovanni Marzot) wrote…
This is in support of local relay "deep" builds?
Artifact/tarball builds presumably have a consistent and pinned version of all deps (in theory if as designed?)
Yes this is the deep-build script we've been using while you've been putting other systems in place. It predates everything else (standlone, tar balls) and the design is to minimize what gets rebuilt after e.g. git pull --rebase. But we also don't want to miss rebuilding something we should have, hence this script.
I think @michalhosna and @akash-a-n are likely using it until we have something better in place.
gmarzot
left a comment
There was a problem hiding this comment.
@gmarzot reviewed 1 file and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind).
|
this can be closed based on recent refactor in build.sh --from-source ? @afrind |
Yes, but I'd like to have similar functionality in --from-source and eliminate the two-step ./build.sh setup and ./build.sh by autodetecting the need for it. claude and I have ideas @gmarzot. |
Track moxygen's full dependency manifest tree so changes to any
upstream manifest trigger a full setup-deps.sh run. Use getdeps.py
to derive the manifest list dynamically rather than maintaining it
by hand.
Add .build-rev stamps after each meta dep build and check them in
meta_deps_installed() so that incomplete or interrupted installs
trigger a rebuild on the next run. Write stamps in save_stamps() so
initial setup via setup-deps.sh also produces them.
Also updates the submodule hash that fixes pico's getdeps file
This change is