Skip to content

Improve build change detection - #55

Closed
afrind wants to merge 2 commits into
mainfrom
manifest-change-detection
Closed

Improve build change detection#55
afrind wants to merge 2 commits into
mainfrom
manifest-change-detection

Conversation

@afrind

@afrind afrind commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Track moxygen's full dependency manifest tree so changes to any
upstream manifest trigger a full setup-deps.sh run. Use getdeps.py
to derive the manifest list dynamically rather than maintaining it
by hand.

Add .build-rev stamps after each meta dep build and check them in
meta_deps_installed() so that incomplete or interrupted installs
trigger a rebuild on the next run. Write stamps in save_stamps() so
initial setup via setup-deps.sh also produces them.

Also updates the submodule hash that fixes pico's getdeps file


This change is Reviewable

afrind added 2 commits March 12, 2026 20:07
Track moxygen's full dependency manifest tree so changes to any
upstream manifest trigger a full setup-deps.sh run. Use getdeps.py
to derive the manifest list dynamically rather than maintaining it
by hand.

Add .build-rev stamps after each meta dep build and check them in
meta_deps_installed() so that incomplete or interrupted installs
trigger a rebuild on the next run. Write stamps in save_stamps() so
initial setup via setup-deps.sh also produces them.
@gmarzot

gmarzot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

-- commits line 8 at r1:
This is in support of local relay "deep" builds?
Artifact/tarball builds presumably have a consistent and pinned version of all deps (in theory if as designed?)

@gmarzot gmarzot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarzot reviewed 2 files and all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on afrind).

@afrind afrind left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on akash-a-n, gmarzot, and michalhosna).


-- commits line 8 at r1:

Previously, gmarzot (Giovanni Marzot) wrote…

This is in support of local relay "deep" builds?
Artifact/tarball builds presumably have a consistent and pinned version of all deps (in theory if as designed?)

Yes this is the deep-build script we've been using while you've been putting other systems in place. It predates everything else (standlone, tar balls) and the design is to minimize what gets rebuilt after e.g. git pull --rebase. But we also don't want to miss rebuilding something we should have, hence this script.

I think @michalhosna and @akash-a-n are likely using it until we have something better in place.

@gmarzot gmarzot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarzot reviewed 1 file and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on afrind).

@gmarzot

gmarzot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

this can be closed based on recent refactor in build.sh --from-source ? @afrind

@afrind

afrind commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

this can be closed based on recent refactor in build.sh --from-source ?

Yes, but I'd like to have similar functionality in --from-source and eliminate the two-step ./build.sh setup and ./build.sh by autodetecting the need for it. claude and I have ideas @gmarzot.

@afrind afrind closed this Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants