Fix Docker runtime link failures, add smoke test - #57
Merged
Conversation
Split docker build/push in publish job with ldd + dump-config-schema smoke test between them. Remove libfmt9 from Dockerfile since moxygen tarball now bundles fmt statically. Simplify publish job by removing single-item matrix.
gmarzot
changed the title
…flow - Rename format job to check-format in ci-main and ci-pr workflows - Simplify notifications to 3 statuses: verify, publish, release (verify combines check-format + build results) - Replace dump-config-schema smoke test with admin /info health check (starts relay, hits GET /info, verifies "service":"o-rly" response) - Add update-moxygen-submodule.yml workflow_dispatch - Update moxygen submodule to e7a5914 (static fmt/sodium, unified matrix)
gmarzot
marked this pull request as draft
March 14, 2026 13:47
- Dockerfile: build o-rly inside debian:bookworm against bookworm moxygen tarball, copy binary to bookworm-slim runtime image - ci-main.yml publish: download bookworm tarball via ORLY_PLATFORM override, docker build does compilation (no C++ toolchain on runner) - setup-deps-tarball.sh: support ORLY_PLATFORM env var override - .dockerignore: exclude build dirs, keep fbcode_builder/CMake - Update moxygen submodule to b3e8ab9 (find_dependency(fmt) fix)
glog dual-linking conflict under ASAN — will revert once glog moves to FetchContent in the moxygen tarball.
Tests multi-stage Docker build + smoke test in CI where network is fast. Downloads bookworm tarball, builds image, verifies ldd and admin /info endpoint. Remove after validation.
The o-rly binary dynamically links libsodium.so.23 and libboost_context.so.1.74.0 — present in the builder stage from -dev packages but missing in bookworm-slim.
The san preset had CMAKE_FIND_LIBRARY_SUFFIXES=".a" which caused find_dependency(Glog) to find libglog.a, while the tarball's folly-targets.cmake hardcodes libglog.so. Both copies loaded under ASAN, crashing on glog's logtostderr flag double-registration. Removing the static preference lets the san build link consistently against .so files for system deps. Also reverts the temporary continue-on-error for asan.
gmarzot
marked this pull request as ready for review
March 15, 2026 12:19
Contributor
Author
|
NOTE: Requires moxygen PR #80 to be merged first, and fully complete CI/publish |
Temporarily download from PR #80 publish-test artifacts (run 23109570855) instead of setup-deps-tarball.sh to validate the .so preference fix. Add libgoogle-glog0v5, libgflags2.2, libdouble-conversion3 to Docker runtime stage (needed now that tarball hardcodes .so paths). Revert TEMPORARY ci-pr.yml changes after PR #80 merges to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #53
Background
The o-rly Docker image (
ghcr.io/openmoq/o-rly) fails at runtime with:Root cause: The moxygen tarball dynamically linked libfmt and libsodium.
Fixed on the moxygen side (openmoq/moxygen#77, merged): fmt built from source
via FetchContent,
sodium_USE_STATIC_LIBS=ON. libunwind stays dynamicintentionally (
libunwind.anot PIC on x86_64).Changes
libfmt9— onlylibunwind8needed at runtime/infoendpoint, verify"service":"o-rly"response. Gates Docker push.format→check-formatin both ci-main and ci-pr workflowsverify(check-format + build),publish(tarball + Docker + smoke),releaseupdate-moxygen-submodule.yml: workflow_dispatch to create a PRupdating deps/moxygen to latest main
e7a59145(static linking + unified matrix)Test plan
This change is