Add handling of unknown control message, avoid blocking - #4
Merged
Conversation
mondain
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MOQT control-stream handling to ensure unrecognized/unhandled control messages don’t stall parsing and block subsequent request processing.
Changes:
- Expand control message type name mapping for additional MOQT message types.
- In
serve_subscriptions(), skip (and log) any control messages that aren’t acted upon to avoid buffer blockage. - In
next_control_message(), add a fallback path intended to consume unknown control message types as length-prefixed messages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/transport/moqt_session.cpp |
Skips unhandled control message types to prevent control-buffer blocking; adds logging and more type-name mappings. |
src/transport/moqt_control_messages.cpp |
Changes control-message boundary detection to attempt consuming unknown message types instead of blocking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…known/corrupt messages
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add handling of unknown control message, to avoid FETCH blocking message processing
Validation
cmake -S . -B buildcmake --build buildctest --test-dir build --output-on-failureProtocol Impact
Notes
Anything reviewers should pay special attention to.