TRUNK-6279: Migrate PersonName from Hibernate Mapping XML to JPA annotations #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the PersonName class with JPA Caching Upadate the OrderServiceTest class with annotated class Modify the PersonName entity class with JPA annotations Remove the PersonName.hbm.xml file
dulmik2003
force-pushed
the
TRUNK-5930
branch
from
013d8d2 to
3aaa971
Compare
ManojLL
suggested changes
Feb 16, 2025
| @@ -54,7 +54,7 @@ | |||
| <mapping resource="org/openmrs/api/db/hibernate/Person.hbm.xml" /> | |||
| <mapping resource="org/openmrs/api/db/hibernate/PersonAttribute.hbm.xml" /> | |||
| <mapping resource="org/openmrs/api/db/hibernate/PersonMergeLog.hbm.xml" /> | |||
| <mapping resource="org/openmrs/api/db/hibernate/PersonName.hbm.xml" /> | |||
| <!-- <mapping resource="org/openmrs/api/db/hibernate/PersonName.hbm.xml" />--> | |||
There was a problem hiding this comment.
remove this commented code
ManojLL
suggested changes
Feb 16, 2025
ManojLL
suggested changes
Feb 17, 2025
| @@ -11,6 +11,15 @@ | |||
|
|
|||
| import static org.apache.commons.lang3.StringUtils.defaultString; | |||
|
|
|||
| import javax.persistence.Cacheable; | |||
Co-Authored-By: Manoj Lakshan <[email protected]>
dulmik2003
force-pushed
the
TRUNK-5930
branch
from
7cf2e29 to
5983633
Compare
ManojLL
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
👉 https://openmrs.atlassian.net/browse/TRUNK-5930