TRUNK-5842: ProgramWorkflow-Domain---Switching-from-Hibernate-Mapping #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Isabirye1515 Thanks for PR, please rename the PR title and add ticket ID |
ManojLL
reviewed
Feb 18, 2025
Comment on lines
64
to
66
|
|
||
|
|
||
|
|
| @@ -271,7 +295,8 @@ public Integer getProgramWorkflowId() { | |||
| public void setProgramWorkflowId(Integer programWorkflowId) { | |||
| this.programWorkflowId = programWorkflowId; | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
Comment on lines
50
to
53
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "program_workflow_id") | ||
| private Integer programWorkflowId; |
There was a problem hiding this comment.
use the existing ID property and configure sequence generation as in the XML mapping
| private Program program; | ||
|
|
| private Concept concept; | ||
|
|
There was a problem hiding this comment.
why did you update the this test?
There was a problem hiding this comment.
Since annotation makes strict db persistance and the class i was extending the name property was nullable false and a field
Isabirye1515
changed the title
|
Can you look into the build failures? |
Comment on lines
-383
to
-391
| <program_workflow program_workflow_id="3" program_id="3" concept_id="1484" creator="6" date_created="2006-09-27 20:34:45.0" retired="false" uuid="cf8f2664-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="4" program_id="4" concept_id="1484" creator="6" date_created="2006-09-27 20:35:03.0" retired="false" uuid="cf8f2934-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="5" program_id="5" concept_id="1846" creator="1128" date_created="2007-03-12 21:48:00.0" retired="false" uuid="cf8f2ad8-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="6" program_id="6" concept_id="1484" creator="1128" date_created="2007-03-28 10:11:39.0" retired="false" uuid="cf8f2c72-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="7" program_id="6" concept_id="5272" creator="1128" date_created="2007-03-28 11:03:03.0" retired="false" uuid="cf8f2e16-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="9" program_id="3" concept_id="3070" creator="1128" date_created="2007-05-03 09:35:38.0" retired="false" uuid="cf8f2fa6-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="10" program_id="4" concept_id="1378" creator="1128" date_created="2007-05-03 10:05:42.0" retired="false" uuid="cf8f3140-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="19" program_id="10" concept_id="1484" creator="15887" date_created="2007-10-29 22:31:52.0" retired="false" uuid="cf8f32da-2700-102b-80cb-0017a47871b2"/> | ||
| <program_workflow program_workflow_id="20" program_id="10" concept_id="3070" creator="6" date_created="2008-05-18 18:15:19.0" retired="false" uuid="25bce7b8-bddf-440a-b939-a9cc11f03a27"/> |
There was a problem hiding this comment.
Ensure UUID uniqueness, consistent date formats, and proper retired status handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngs-to-Annotation
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master