TRUNK-6260: Add Commons Collections 4 to the provided set of libraries #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
reviewed
Apr 2, 2025
There was a problem hiding this comment.
You probably should take a look at https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips
|
@mherman22 I have gone through the docs but unable to understand what specific change you are pointing to. |
agrpranjal07
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
see TRUNK-6260: Add Commons Collections 4 to the provided set of libraries
Description of what I changed
I had changed Commons Collection package to version 4 in all the file
Changed api/src/main/java/org/openmrs/api/db/hibernate/HibernateConceptDAO.java to make it compatible with version 4.
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.