Skip to content

Fix: correct assertion message in StorageServiceTest for storage dir validation #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nanna3210
Copy link

Description of what I changed

Corrected the expected error message in StorageServiceTest#getDataShouldFailIfKeyTriesToAccessFilesOutsideStorageDir to match the actual exception message and ensure test passes.

Issue I worked on

No existing issue. Found this test failure while building the project.

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.
  • I have added tests to cover my changes. (Test was already present; just fixed the assertion)
  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@atulyadav745
Copy link

Hey @nanna3210 Thank you for working on this,
I would highly encourage to create an issue on JIRA before actually making a PR and mention the issue number in your PR.
Title for Pr should be <issue_number>_what_changes_your_PR_proposes
I would suggest you to go through the OpenMRS contribution Guidelines
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants