TRUNK-6058: Create CI Process to create liquibase snapshots #5305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamMujuziMoses
force-pushed
the
TRUNK-6058
branch
12 times, most recently
from
3828f03 to
aaa7261
Compare
Contributor
Author
Member
|
The idea of the ticket is just to automate the process described here. I can't imagine that we can merge this as-is without breaking things, since you've now turned the api JAR (which we use everywhere) into a shaded JAR. |
IamMujuziMoses
commented
Sep 16, 2025
api/pom.xml
Outdated
Comment on lines
375
to
377
| <createDependencyReducedPom>false</createDependencyReducedPom> | ||
| <shadedArtifactAttached>true</shadedArtifactAttached> | ||
| <shadedClassifierName>shaded</shadedClassifierName> |
Contributor
Author
There was a problem hiding this comment.
@ibacher, I think the API jar is still there and published as usual, the shaded jar is just an extra deliverable for the CI snapshot process
IamMujuziMoses
force-pushed
the
TRUNK-6058
branch
from
aaa7261 to
eded28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6058
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master