Skip to content

TRUNK-6646: Env-var key normalization drops create_database_* / create_user_* credentials in scripted setup#6145

Open
jwnasambu wants to merge 5 commits into
openmrs:masterfrom
jwnasambu:TRUNK-6646
Open

TRUNK-6646: Env-var key normalization drops create_database_* / create_user_* credentials in scripted setup#6145
jwnasambu wants to merge 5 commits into
openmrs:masterfrom
jwnasambu:TRUNK-6646

Conversation

@jwnasambu
Copy link
Copy Markdown
Contributor

@jwnasambu jwnasambu commented May 29, 2026

Description of what I changed

I expanded NON_NORMALIZED_KEYS: By adding the following keys to the allow list to prevent incorrect normalization (preserving underscores):
* CONNECTION_DRIVER_CLASS
* CREATE_DATABASE_USERNAME
* CREATE_DATABASE_PASSWORD
* CREATE_USER_USERNAME
* CREATE_USER_PASSWORD
Also I updated the initializeWizardFromResolvedPropertiesIfPresent method to resolve the database driver from both connection.driver_class (dot notation) and connection_driver_class (underscore notation). This ensures compatibility regardless of whether the value comes from a runtime properties file or a normalized environment variable.

Issue I worked on

https://openmrs.atlassian.net/issues?filter=10641&selectedIssue=TRUNK-6646

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.35%. Comparing base (a711ef6) to head (17d8081).

Files with missing lines Patch % Lines
...eb/filter/initialization/InitializationFilter.java 82.35% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6145      +/-   ##
============================================
- Coverage     59.38%   59.35%   -0.04%     
- Complexity     9337     9340       +3     
============================================
  Files           695      695              
  Lines         37448    37457       +9     
  Branches       5515     5517       +2     
============================================
- Hits          22238    22232       -6     
- Misses        13204    13217      +13     
- Partials       2006     2008       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jwnasambu jwnasambu force-pushed the TRUNK-6646 branch 5 times, most recently from 952f849 to 02f6df7 Compare June 1, 2026 12:20
@jwnasambu
Copy link
Copy Markdown
Contributor Author

@wikumChamith, @ibacher, @dkayiwa Kindly feel free to share at your convenient time please!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants