TRUNK-6644: Fix footer hiding continue button on displays shorter than 850px#6161
Open
solomonfortune wants to merge 1 commit into
Open
TRUNK-6644: Fix footer hiding continue button on displays shorter than 850px#6161solomonfortune wants to merge 1 commit into
solomonfortune wants to merge 1 commit into
Conversation
|
Member
|
@coderabbitai fullreview |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6161 +/- ##
============================================
- Coverage 59.38% 59.33% -0.05%
Complexity 9337 9337
============================================
Files 695 695
Lines 37448 37448
Branches 5515 5515
============================================
- Hits 22238 22220 -18
- Misses 13204 13216 +12
- Partials 2006 2012 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What was changed
Updated
footer.vmto prevent the fixed footer from overlapping the Continue button during the initial setup wizard on displays with a viewport height smaller than 850px.Why this PR exists
On displays shorter than 850px in height, the fixed-position footer was rendering on top of the Continue/submit button in the setup wizard, making it impossible for users to proceed through the initial setup.
How it was done
max-heighton.content-containerfromcalc(100vh - 180px)tocalc(100vh - 200px)to create more clearance from the footer@media (max-height: 850px)query that increasespadding-bottomon the body and further reduces themax-heightof.content-containertocalc(100vh - 220px), ensuring the content area always remains scrollable and fully above the fixed footer.