Skip to content

TRUNK-6644: Fix footer hiding continue button on displays shorter than 850px#6161

Open
solomonfortune wants to merge 1 commit into
openmrs:masterfrom
solomonfortune:TRUNK-6644
Open

TRUNK-6644: Fix footer hiding continue button on displays shorter than 850px#6161
solomonfortune wants to merge 1 commit into
openmrs:masterfrom
solomonfortune:TRUNK-6644

Conversation

@solomonfortune
Copy link
Copy Markdown

What was changed

Updated footer.vm to prevent the fixed footer from overlapping the Continue button during the initial setup wizard on displays with a viewport height smaller than 850px.

Why this PR exists

On displays shorter than 850px in height, the fixed-position footer was rendering on top of the Continue/submit button in the setup wizard, making it impossible for users to proceed through the initial setup.

How it was done

  • Updated max-height on .content-container from calc(100vh - 180px) to calc(100vh - 200px) to create more clearance from the footer
  • Added a new @media (max-height: 850px) query that increases padding-bottom on the body and further reduces the max-height of .content-container to calc(100vh - 220px), ensuring the content area always remains scrollable and fully above the fixed footer.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

@dkayiwa
Copy link
Copy Markdown
Member

dkayiwa commented Jun 5, 2026

@coderabbitai fullreview

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.33%. Comparing base (a711ef6) to head (cd61ae8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6161      +/-   ##
============================================
- Coverage     59.38%   59.33%   -0.05%     
  Complexity     9337     9337              
============================================
  Files           695      695              
  Lines         37448    37448              
  Branches       5515     5515              
============================================
- Hits          22238    22220      -18     
- Misses        13204    13216      +12     
- Partials       2006     2012       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants