O3-5202: Add “Finalize bill” button with privilege control#573
Draft
ValarCode wants to merge 2 commits intoopenmrs:mainfrom
Draft
O3-5202: Add “Finalize bill” button with privilege control#573ValarCode wants to merge 2 commits intoopenmrs:mainfrom
ValarCode wants to merge 2 commits intoopenmrs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the frontend changes required for O3-5202, adding a “Finalize bill” action to the Invoice view. The button updates the bill status to
POSTEDand refreshes the UI.What’s included
updateBillItemsto send status updates to the backendgetBillableServiceUuid(same pattern as Edit Bill Line Item)userHasAccess()so only users with the configured privilege see the buttonTesting
yarn verify(all tests passing locally)status === "PENDING"Backend note
When changing the bill status to
POSTED, the backend currently returns:This seems related to the billing rounding configuration on my local environment, not the payload.
I’ve asked on the Jira ticket for guidance on rounding configuration requirements.
JIRA
https://openmrs.atlassian.net/browse/O3-5202