(feat) O3-5299: Enhance WCAG 2.1 compliance for search components#356
Open
sanks011 wants to merge 4 commits intoopenmrs:mainfrom
Open
(feat) O3-5299: Enhance WCAG 2.1 compliance for search components#356sanks011 wants to merge 4 commits intoopenmrs:mainfrom
sanks011 wants to merge 4 commits intoopenmrs:mainfrom
Conversation
…uilder - Add complete keyboard navigation with arrow keys, Enter, Escape - Implement WCAG 2.1 AA compliant form structures and ARIA patterns - Add professional error handling and loading state announcements - Fix screen reader compatibility with proper sr-only classes - Enhance focus management and visual indicators - Remove duplicate scrollbars and redundant UI elements - Add 25+ accessibility-focused translation keys Addresses documented accessibility barriers identified in professional OpenMRS audits. Ensures healthcare compliance and improves usability for users with disabilities.
sanks011
changed the title
sanks011
changed the title
| width: 100%; | ||
| max-height: 400px; | ||
| overflow: auto; | ||
| overflow: visible; |
There was a problem hiding this comment.
Was this change intentional to prevent clipping of focus indicators? If so, consider using overflow: visible only for the z-axis and keep overflow-y: auto to handle vertical scrolling.
Author
There was a problem hiding this comment.
@RajPrakash681 Good catch! You're right - changing to overflow: visible broke scrolling and wasn't actually needed.
The focus indicators are inside .conceptList (which has its own overflow-y: auto), so .search's overflow wasn't the clipping boundary anyway.
Fixed by:
- Reverting
.searchtooverflow-y: auto - Using
insetbox-shadow on.focusedso focus indicators stay within the scroll container
Thanks for the review! 🙌
|
@sanks011 else nice work! |
…ng focused item visibility
…011/openmrs-esm-cohortbuilder-app into accessibility-improvements
Author
Thank You! |
denniskigen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR significantly enhances accessibility compliance across the cohort builder's search components, implementing comprehensive WCAG 2.1 AA standards for healthcare applications.
Key Improvements:
Components Enhanced:
Healthcare Compliance:
Screenshots
Related Issue
Jira Ticket: https://openmrs.atlassian.net/browse/O3-5299
This is a proactive accessibility improvement addressing documented OpenMRS accessibility needs.
Other