O3-4574 Correct rendering of ICRC forms and Distress scales #100
Conversation
| "jest-environment-jsdom": "^28.1.3", | ||
| "lodash-es": "^4.17.21", | ||
| "openmrs": "next", | ||
| "openmrs": "^6.2.1-pre.2825", |
There was a problem hiding this comment.
@krishna-shrivastav232702 Is there a specific need for the package updates, or were they introduced unintentionally?
There was a problem hiding this comment.
Yes, to the best of my knowledge, a package update is needed to resolve the useLeftNavStore issue because the packages automatically changed when i ran the command "yarn up openmrs@next @openmrs/esm-framework@next" please correct me if i am wrong
There was a problem hiding this comment.
Got it thanks for explaining. However, wouldn't it have been better to address the useLeftNavStore issue separately instead of updating packages together? Just want to make sure we're not introducing unintended changes.
There was a problem hiding this comment.
As per the Slack discussions, the fast-data-entry app is broken and should be fixed as part of GSoC 2025. The app is breaking due to missing functions, and the documentation states that this command should be run if any functions are missing. You can refer to this Slack chat: https://openmrs.slack.com/archives/C03U8H2AY/p1742489600215209
There was a problem hiding this comment.
Hey,@Pratibha0280 @krishna-shrivastav232702 it is best practice to discard the changes that have happened to the yarn.lock file before pushing the pr.
|
@samuelmale @denniskigen can you please review my PR ?? |
3 participants
Requirements
Summary
This PR addresses an issue where the ICRC forms and distress scales were not rendering the object properly. Changes have been made to FormsPage.tsx to ensure that the data is correctly displayed.
Screenshots
Before
After
Ticket URL : https://openmrs.atlassian.net/browse/O3-4574