(Test) O3-5000 : Added unit tests to the Translation Builder Component #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Jan 12, 2026
| ], | ||
| "module": "esnext", | ||
| "moduleResolution": "node", | ||
| "ignoreDeprecations":"5.0", |
Member
There was a problem hiding this comment.
Suggested change
| "ignoreDeprecations":"5.0", |
Shouldn't be necessary to modify the TypeScript config.
Member
There was a problem hiding this comment.
We don't support React 19 yet, so we can undo changes to the lockfile.
Comment on lines
-85
to
-86
| "@types/react": "^18.3.2", | ||
| "@types/react-dom": "^18.3.0", |
Member
There was a problem hiding this comment.
Ditto about React 19 support.
Comment on lines
+11
to
+12
| jest.mock('@hooks/getLanguageOptionsFromSession'); | ||
| jest.mock('@hooks/useBackendTranslations'); |
Member
There was a problem hiding this comment.
See our recommended mocking patterns for the canonical way to stub mocks.
| const mockedShowSnackbar = showSnackbar as jest.Mock; | ||
|
|
||
| beforeAll(() => { | ||
| Object.defineProperty(window, 'matchMedia', { |
Member
There was a problem hiding this comment.
This should be in setupTests.ts or similar.
Comment on lines
+73
to
+76
| mockedShowSnackbar.mockReset(); | ||
| mockedShowModal.mockReset(); | ||
| mockedUploadTranslations.mockReset(); | ||
| mockedFetchTranslations.mockClear(); |
Member
There was a problem hiding this comment.
The top-level jest config should have a clearMocks: true option that resets all mocks per test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds unit tests to improve reliability and ensure correct behavior of the Translation Builder
Key Test Coverage:
Rendering: Verify Translation Builder UI renders with schema (tabs, dropdown, buttons, search).
Translations Display: Confirm fallback and overridden translations appear correctly.
Editing: Validate EditTranslationModal opens, updates schema on save, and cancels without changes.
Filtering & Search: Ensure tabs (All/Translated/Untranslated) and search filtering work.
Language Switching: Confirm translations update when switching languages, including backend merge.
Download: Test translation download, with error handling when no translations exist.
Upload: Mock upload flow with success and failure cases, showing proper snackbar messages
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-5000
Other
None