(tests) O3-4316: Add unit tests for obsGroup type questions #416
Conversation
|
Hi @NethmiRodrigo , could you review this PR Thanks! |
src/components/interactive-builder/modals/question/question.modal.test.tsx
Outdated
Show resolved
Hide resolved
| }, | ||
| }, | ||
| ], | ||
| } as ObsGroupQuestion, |
There was a problem hiding this comment.
Is this as ObsGroupQuestion required?
| render( | ||
| <FormFieldProvider initialFormField={initialFormField}> | ||
| <QuestionModal | ||
| closeModal={mockCloseModal} | ||
| schema={mockSchema} | ||
| pageIndex={0} | ||
| sectionIndex={0} | ||
| questionIndex={0} | ||
| onSchemaChange={mockOnSchemaChange} | ||
| resetIndices={mockResetIndices} | ||
| formField={initialFormField} | ||
| /> | ||
| </FormFieldProvider>, | ||
| ); |
There was a problem hiding this comment.
Prefer to have the `renderComponent as a separate function like so -
| ); | ||
|
|
||
| expect(screen.getByText(/Question type/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/Rendering type/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
You should also make sure that the button Add grouped question is visible
| jest.mock('react-i18next', () => ({ | ||
| useTranslation: () => ({ | ||
| t: (key, defaultValue) => defaultValue || key, | ||
| }), | ||
| })); |
There was a problem hiding this comment.
Is this required? We already have a mock for react-i18next in https://github.com/openmrs/openmrs-esm-form-builder/blob/main/__mocks__/react-i18next.js
There was a problem hiding this comment.
We should also test for things like adding a grouped question renders the input fields for another question and that deleting an obsgroup question does actually delete it
…dal.test.tsx Co-authored-by: Nethmi Rodrigo <[email protected]>
Co-authored-by: Nethmi Rodrigo <[email protected]>
| label: 'Vital Signs', | ||
| type: 'obsGroup', | ||
| questionOptions: { | ||
| rendering: 'group' as RenderType, |
There was a problem hiding this comment.
do we need explicit casting here?
| label: 'Blood Pressure', | ||
| type: 'obs', | ||
| questionOptions: { | ||
| rendering: 'text' as RenderType, |
There was a problem hiding this comment.
| rendering: 'text' as RenderType, | |
| rendering: 'text' , |
| label: 'Temperature', | ||
| type: 'obs', | ||
| questionOptions: { | ||
| rendering: 'number' as RenderType, |
There was a problem hiding this comment.
| rendering: 'number' as RenderType, | |
| rendering: 'number', |
NethmiRodrigo
changed the title
Requirements
Summary
This PR adds unit tests for obsGroup type questions in the form engine. The tests validate the proper rendering and functionality of obsGroup components, ensuring they correctly handle nested observations and maintain data integrity.
Screenshots
N/A - This PR focuses on unit tests without UI changes.
Related Issue
https://openmrs.atlassian.net/browse/O3-4316
Other
The added tests improve coverage for the obsGroup functionality which was previously untested.