(fix) O3-4581: Reset the rendering type when the question type changes #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to remove rendering type value if the previously selected rendering type value is not present for the new question type
There was a problem hiding this comment.
Hey @yoursanonymous , I noticed that the code directly mutates the formField object using the delete operator.
Instead, I would suggest to create a new object without the questionOptions property when needed. This way, the state updates cleanly and predictably.
NethmiRodrigo
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Thanks @yoursanonymous, please include a screen recording of before and after the fix
...components/interactive-builder/modals/question/question-form/question/question.component.tsx
Outdated
Show resolved
Hide resolved
1. Added a separate function to handle formField change 2. Removed directly deleting line to avoid directly mutating the formField object
|
we can see that the rendering type was automatically selected as the first dropdown value before.mp4now we can see that it is asking us to choose a rendering type instead of automatically selecting first drop down value after we changed the question type after.mp4 |
NethmiRodrigo
requested changes
Apr 4, 2025
...components/interactive-builder/modals/question/question-form/question/question.component.tsx
Outdated
Show resolved
Hide resolved
...components/interactive-builder/modals/question/question-form/question/question.component.tsx
Outdated
Show resolved
Hide resolved
NethmiRodrigo
changed the title
NethmiRodrigo
changed the title
...components/interactive-builder/modals/question/question-form/question/question.component.tsx
Outdated
Show resolved
Hide resolved
...components/interactive-builder/modals/question/question-form/question/question.component.tsx
Outdated
Show resolved
Hide resolved
NethmiRodrigo
approved these changes
Apr 10, 2025
|
Hi @NethmiRodrigo , Thankyou for approving my PR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to remove rendering type value if the previously selected rendering type value is not present for the new question type
Requirements
Summary
Rendering type was same even after changing the Question type and in UI it selects the 1st dropdown value if previous selected rendering type is not available
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4581
Other