(feat) O3-4171 : Validate concept answers and show error for non-existing answers #445
Conversation
|
Hey @NethmiRodrigo should i stick with this endpoint |
| setInvalidAnswerFound(!allValid); | ||
| }; | ||
|
|
||
| validateAnswers(); |
There was a problem hiding this comment.
Since you are calling this function inside useEffect, the function should be defined outside the useEffect hook.
| if (originalAnswerIds.has(answer.id)) { | ||
| continue; | ||
| } else { | ||
| const url = `${restBaseUrl}/concept/${answer.id}?v=full`; |
There was a problem hiding this comment.
Please use the useConceptId hook.
For future reference, we don't usually do API calls within the component like this. We make hooks - https://o3-docs.openmrs.org/docs/coding-conventions/data-fetching.
There was a problem hiding this comment.
@NethmiRodrigo But we can't directly use the hook inside the loop right??
| {invalidAnswerFound && ( | ||
| <InlineNotification | ||
| kind="error" | ||
| lowContrast | ||
| className={styles.error} | ||
| title={t('invalidAnswerConcept', 'Invalid Answer Concept Detected')} | ||
| subtitle={t('answerConceptValidation', 'One or more selected answer concepts do not exist in the system. ')} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
This is good, maybe we can show a not found icon within the blue tag of the answer that is invalid. Otherwise we'd have to guess which ones are invalid.
Requirements
Summary
Screenshots
Screen.Recording.2025-04-08.190713.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4171
Other