(fix) O3-4613 Removing previous sub properties from Form json after changing Question and Rendering Type

[yoursanonymous]

…roup button

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

When we create a question of type "encounterDateTime", we have radio buttons of "type of date picker to show" should be selected when we save a form but, it's not working.

Screenshots

Before

beforeSave.mp4

After

afterSave.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-4613

Other

[atulyadav745]

Thanks @yoursanonymous, great catch! Really appreciate you pointing this out.

[NethmiRodrigo]

I don't think its really necessary to default pick a datepicker type for this, but if we are doing it, its much better to set it here when the rendering type is being set rather than use an useEffect-

openmrs-esm-form-builder/src/components/interactive-builder/modals/question/question-form/question/question.component.tsx

Line 105 in b5221ee

const updatedObject: FormField =

.
We should avoid the usage of useEffects wherever we can - https://react.dev/learn/you-might-not-need-an-effect

[yoursanonymous]

Hi @NethmiRodrigo, Thank you for reviewing my PR,
Sorry just realized by looking at a similar 'ui-select-extended' component that using 'defaultSelected' property of RadioButtonGroup would be a better way to set the default value for Date picker type, made the required changes as well.

Could you please review it again.

[yoursanonymous]

Hi @NethmiRodrigo, after trying out multiple scenarios the issue was found to be pretty big one in which when we change the rendering type, the subsequent subproperties of previous rendering type was not removed from the Form json and the default value selected for various fields in interactive builder was also not added automatically by default to json object.

[yoursanonymous]

before.o3-4613.mp4

after.o3-4613.mp4

[yoursanonymous]

Removing unnecesary fields during questionType change.

beforeQuestion1.mp4

afterQuestion.mp4

[yoursanonymous]

Hi @NethmiRodrigo, awaiting your approval, Kindly review

[NethmiRodrigo]

Hi @NethmiRodrigo, after trying out multiple scenarios the issue was found to be pretty big one in which when we change the rendering type, the subsequent subproperties of previous rendering type was not removed from the Form json and the default value selected for various fields in interactive builder was also not added automatically by default to json object.

@yoursanonymous The issue you've pivoted to address is already being worked on in PR #391, which has several comments and insights on how to fix it properly.
You have two good options moving forward:

1. Revert this PR back to your original scope (addressing the initial ticket with the suggestions I provided in my first two reviews, which is sufficient to fix your initial problem, this current issue that you are addressing doesn't affect that)
2. Collaborate on PR (fix) O3-4320: Remove Irrelevant Properties When Changing Question Type #391 if you're particularly interested in solving that specific issue

For future reference, it's best practice to keep PRs focused on their original scope. If you want to work on a different issue, please open a new PR rather than changing direction mid-review. This wastes reviewer time and disrupts our development process. One PR = one focused purpose.
I'm happy to help get your original work merged if you decide to go back to option 1.