(fix) O3-4613 Choosing a default radio button "type of date picker to show" radio group

[yoursanonymous]

…roup button

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

When we create a question of type "encounterDateTime", we have radio buttons of "type of date picker to show" should be selected when we save a form but, it's not working.

Screenshots

Before

beforeSave.mp4

After

afterSave.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-4613

Other

[atulyadav745]

Thanks @yoursanonymous, great catch! Really appreciate you pointing this out.

[NethmiRodrigo]

I don't think its really necessary to default pick a datepicker type for this, but if we are doing it, its much better to set it here when the rendering type is being set rather than use an useEffect-

openmrs-esm-form-builder/src/components/interactive-builder/modals/question/question-form/question/question.component.tsx

Line 105 in b5221ee

const updatedObject: FormField =

.
We should avoid the usage of useEffects wherever we can - https://react.dev/learn/you-might-not-need-an-effect

[yoursanonymous]

Hi @NethmiRodrigo, Thank you for reviewing my PR,
Sorry just realized by looking at a similar 'ui-select-extended' component that using 'defaultSelected' property of RadioButtonGroup would be a better way to set the default value for Date picker type, made the required changes as well.

Could you please review it again.

[NethmiRodrigo]

using 'defaultSelected' property of RadioButtonGroup would be a better way to set the default value for Date picker type, made the required changes as well.

Using the defaultSelected that would mean that the user gets the impression that when they save the defaultSelected value would be persisted, but that isn't the case here. To fix that, referring back to my first suggestion, you'd have to set the datePickerFormat in the formField while using the defaultSelected here