(fix) Make the whole label as tooltip trigger #475
+44
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
reviewed
Mar 13, 2025
|
Size Change: -266 kB (-16.02%) 👏 Total Size: 1.39 MB
ℹ️ View Unchanged
|
vasharma05
force-pushed
the
fix/tooltip-alignment
branch
from
cbf6db6 to
071c102
Compare
vasharma05
changed the title
vasharma05
force-pushed
the
fix/tooltip-alignment
branch
from
1538c46 to
887fd00
Compare
vasharma05
force-pushed
the
fix/tooltip-alignment
branch
from
887fd00 to
46a73c6
Compare
samuelmale
reviewed
Apr 10, 2025
| const Tooltip: React.FC<{ field: FormField; children: React.ReactNode }> = ({ field, children }) => { | ||
| const { t } = useTranslation(); | ||
| return ( | ||
| <CarbonTooltip align="top-left" label={t(field.questionInfo)} defaultOpen> |
There was a problem hiding this comment.
I think defaultOpen should not be enabled.
There was a problem hiding this comment.
I thought I removed this, apologies.
| hasTooltip: boolean; | ||
| } | ||
|
|
||
| const FieldLabelContent: React.FC<FieldLabelContentProps> = ({ field, customLabel, hasTooltip }) => { |
There was a problem hiding this comment.
@vasharma05 Splitting these components feels overkill. Here is a simplified version: https://gist.github.com/samuelmale/daef56444bc7e8ea79c044dc842dec37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, the
iicon is shown on the right hand of the label which is then used to trigger the tooltip. Now the tooltip rendered was getting cropped by the form's wrapper.Now the whole label is made the tooltip trigger, along with displaying a
iicon on the right side of the label.Screenshots
Before
After
Related Issue
Other
Slack thread: https://openmrs.slack.com/archives/C04QZ5DDVMG/p1743764918799569