(feat)O3-4447: Validate visit start/end time against overlapping visits

[RajPrakash681]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work is based on designs, which are linked or shown either in the Jira ticket or the description below. (See also: Styleguide)
• My work includes tests or is validated by existing tests.

Summary

This PR adds client-side validation to prevent users from creating visits that overlap with existing visits for the same patient. Previously, overlapping visits could only be caught by the server, resulting in 400 errors. Now users receive immediate feedback when attempting to create or edit a visit that conflicts with an existing one.

Key changes:

• Implemented overlap detection algorithm that checks all existing patient visits
• Added async validation using custom resolver pattern (similar to visit-notes-form)
• Handles edge cases: ongoing visits, edit mode, and adjacent non-overlapping visits
• Added comprehensive test coverage (11 new tests)

Screenshots

N/A - This is a validation enhancement with no UI changes. Error messages are displayed inline on existing form fields.

Related Issue

https://openmrs.atlassian.net/browse/O3-4447

Other

• Compatible with PR (feat) O3-4443 Add ability to create a visit that ended in the past #2240 (Retrospective Data Entry)
• Gracefully handles API failures without blocking form submission

[chibongho]

Pulling all visits from the patient to check for overlaps on the frontend is inefficient. We should query the backend for visits within the overlapping range instead. I'm not sure if the backend already supports that; if not, we should implement it there.

[RajPrakash681]

Thanks for the feedback @chibingho!

I looked into the backend API and found that it partially supports date filtering:

The /visit endpoint has a fromStartDate parameter to filter visits starting after a certain date
But there's no toStopDate or overlap-specific filtering

So the backend doesn’t fully support querying visits within an overlapping range.

What would you prefer I do?

Option 1:
I can optimize the current frontend code to use the fromStartDate parameter to reduce the data fetched
Option 2:
I can work on adding a proper backend endpoint for overlap checking

[chibongho]

The /visit endpoint has a fromStartDate parameter to filter visits starting after a certain date But there's no toStopDate or overlap-specific filtering

Where did you see that?

[RajPrakash681]

The /visit endpoint has a fromStartDate parameter to filter visits starting after a certain date But there's no toStopDate or overlap-specific filtering

Where did you see that?

fromStartDate is documented, but there's no toStopDate, toStartDate, or any overlap-specific parameters available

[chibongho]

Ahh, sorry, that page is horribly out of date. I usually need to go directly to the Java code to see what's supported:

https://github.com/openmrs/openmrs-module-webservices.rest/blob/92d4f8faf3a095f0dc59e30e4cb1f3ed86cb0345/omod/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_9/VisitResource1_9.java#L323

So fromStartDate, toStartDate, fromStopDate, toStopDate are all available. I think what we want is:

/visit?patient=<patientUuid>&toStartDate=<newVisitStopDate)&fromStopDate=<newVisitStartDate>

[RajPrakash681]

Ahh, sorry, that page is horribly out of date. I usually need to go directly to the Java code to see what's supported:

https://github.com/openmrs/openmrs-module-webservices.rest/blob/92d4f8faf3a095f0dc59e30e4cb1f3ed86cb0345/omod/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_9/VisitResource1_9.java#L323

So fromStartDate, toStartDate, fromStopDate, toStopDate are all available. I think what we want is:

/visit?patient=<patientUuid>&toStartDate=<newVisitStopDate)&fromStopDate=<newVisitStartDate>

ok got it!

[RajPrakash681]

@chibongho hello, can you check now!