Skip to content

AOM-175: Add validation checks in getProviderForUser method #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadvik93 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AOM-175: Add validation checks in getProviderForUser method #245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16318ce
AOM-175: Add validation checks in getProviderForUser method
Mar 7, 2026
732ab68
AOM-175: Address review feedback and add user.getPerson() null check
Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions api/src/main/java/org/openmrs/module/legacyui/api/impl/LegacyUIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,23 @@ public void triggerStateConversion(Patient patient, Concept trigger, Date dateCo
*/
@Transactional(readOnly = true)
public Provider getProviderForUser(User user) {
ProviderService ps = Context.getProviderService();
Collection<Provider> providers = ps.getProvidersByPerson(user.getPerson(), true);
if (providers.isEmpty()) {
throw new IllegalStateException("User " + user + " has no provider accounts, unable to create orders");
}
return providers.iterator().next();
if (user == null) {
throw new IllegalArgumentException("User cannot be null");
}

if (user.getPerson() == null) {
throw new IllegalStateException("User has no associated person record");
}

ProviderService ps = Context.getProviderService();

Collection<Provider> providers = ps.getProvidersByPerson(user.getPerson(), true);

if (providers.isEmpty()) {
throw new IllegalStateException("User " + user + " has no provider accounts, unable to create orders");
}

return providers.iterator().next();
}

/**
Expand Down