Skip to content

AOM-182: Replace deprecated Boolean constructor usage in ConceptProposalListController #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadvik93 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

AOM-182: Replace deprecated Boolean constructor usage in ConceptProposalListController #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ protected Object formBackingObject(HttpServletRequest request) throws ServletExc
if (Context.isAuthenticated()) {
ConceptService cs = Context.getConceptService();
log.debug("tmp value: " + request.getParameter("includeCompleted"));
boolean b = new Boolean(request.getParameter("includeCompleted"));
boolean b = Boolean.parseBoolean(request.getParameter("includeCompleted"));
log.debug("b value: " + b);
cpList = cs.getAllConceptProposals(b);
}
Expand All @@ -64,7 +64,7 @@ protected Object formBackingObject(HttpServletRequest request) throws ServletExc
origText.put(cp.getOriginalText(), matchingProposals);
}

boolean asc = new Boolean("asc".equals(request.getParameter("sortOrder")));
boolean asc = "asc".equals(request.getParameter("sortOrder"));
String sortOn = request.getParameter("sortOn");
if (sortOn == null) {
sortOn = "occurences";
Expand Down