RA-2025: Update the demo patient generator to include deceased patients#21
Open
Piumal1999 wants to merge 1 commit intoopenmrs:2.xfrom
Open
RA-2025: Update the demo patient generator to include deceased patients#21Piumal1999 wants to merge 1 commit intoopenmrs:2.xfrom
Piumal1999 wants to merge 1 commit intoopenmrs:2.xfrom
Conversation
Ruhanga
reviewed
May 6, 2024
Member
Ruhanga
left a comment
There was a problem hiding this comment.
Thanks for the PR @Piumal1999. One observation. It is possible that there are several visits following the death date. Those visits wouldn't provide meaningful data. I'd rather have the death date anywhere between during the last visit. This is because in real-life such information is usually recorded during a patient's last visit. Best too if it could be as a result to a certain condition or diagnosis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updated the demo patient generator to include deceased patients.
Used the existing
randomBetweenfunction to establish a 10% probability for a person being deceased. The death date will be a random date between the current day and the date of birth.Jira Ticket
https://openmrs.atlassian.net/browse/RA-2025