Skip to content

Some fixes and changes #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmyrAhmady merged 2 commits into from
Oct 23, 2025
Merged

Some fixes and changes #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2def393
fix console on windows and fix close crash
AmyrAhmady Oct 23, 2025
0b790f0
deprecate Fixes component and disable building
AmyrAhmady Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ set(BUILD_UNICODE_COMPONENT FALSE CACHE BOOL "Whether to build the Unicode compo
set(BUILD_LEGACY_COMPONENTS TRUE CACHE BOOL "Whether to build the legacy components")
set(BUILD_TEST_COMPONENTS FALSE CACHE BOOL "Whether to build the test component")
set(BUILD_SQLITE_COMPONENT TRUE CACHE BOOL "Whether to build the SQLite component")
set(BUILD_FIXES_COMPONENT TRUE CACHE BOOL "Whether to build the Fixes component")
set(BUILD_FIXES_COMPONENT FALSE CACHE BOOL "Whether to build the Fixes component")

if (UNIX)
set(BUILD_ABI_CHECK_TOOL TRUE CACHE BOOL "Whether to build the abi-check tool")
Expand Down
1 change: 1 addition & 0 deletions Server/Components/CAPI/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class CAPIComponent final : public IComponent
COMPONENT_UNLOADED(mgr->textlabels)
COMPONENT_UNLOADED(mgr->vehicles)
COMPONENT_UNLOADED(mgr->models)
COMPONENT_UNLOADED(mgr->npcs)
}

void free() override
Expand Down
3 changes: 0 additions & 3 deletions Server/Components/Console/console_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,7 @@ class ConsoleComponent final : public IConsoleComponent, public CoreEventHandler
threadData = new ThreadProcData { true, this };
cinThread = std::thread(ThreadProc, threadData);
nativeThreadHandle = cinThread.native_handle();

#ifndef WIN32
cinThread.detach();
#endif
}

void onReady() override
Expand Down
Loading