fix: ensure internal x-middleware-set-cookie header is not passed on to lambda
#2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting cookies in middleware
mrstork
changed the title
x-middleware-set-cookie header is not passed on to lambda
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
commented
May 1, 2025
| }, | ||
| { | ||
| "file": "test/e2e/app-dir/app-middleware/app-middleware.test.ts", | ||
| "reason": "Relies on access to environment variables set on the edge", |
There was a problem hiding this comment.
pieh
reviewed
May 3, 2025
| @@ -67,6 +67,10 @@ export function mergeMiddlewareCookies(middlewareResponse: Response, lambdaReque | |||
| const middlewareCookies = middlewareResponse.headers.get('x-middleware-set-cookie') | |||
|
|
|||
| if (middlewareCookies) { | |||
| // Next expects internal headers to be omitted when cookies are set by the middleware | |||
| // See: https://github.com/vercel/next.js/blob/005db43079c7b59fd8c2594e8362761dc4cb3211/test/e2e/app-dir/app-middleware/app-middleware.test.ts#L197-L207 | |||
| middlewareResponse.headers.delete('x-middleware-set-cookie') | |||
There was a problem hiding this comment.
Does final response reaching client (browser/curl etc) would have actual set-cookie with this removal? from what I can see mergeMiddlewareCookies only sets cookie header:
opennextjs-netlify/edge-runtime/lib/response.ts
Lines 245 to 248 in 7795157
so I wonder if this change as-is wouldn't result in clients no longer actually receiving set-cookie headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Middleware cookies depend on the
x-middleware-set-cookie headerto work, however Next does not expect this header to be passed on after the middleware. This change ensures the value is not set when sending the request to the lambda.Tests
Focus is on
should omit internal headers for middleware cookiestestRelevant links (GitHub issues, etc.) or a picture of cute animal
Fixes FRB-1774