Skip to content

update aaas with parallel workflows - #21

Merged
dorien-er merged 8 commits into
mainfrom
update-aaas-with-parallel-workflows
Jul 14, 2026
Merged

update aaas with parallel workflows#21
dorien-er merged 8 commits into
mainfrom
update-aaas-with-parallel-workflows

Conversation

@dorien-er

@dorien-er dorien-er commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
  • update AaaS with parallel integration/annotation workflow
  • extend existing parameters of OP to AaaS

@dorien-er
dorien-er requested a review from jakubmajercik July 13, 2026 09:37

@jakubmajercik jakubmajercik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be relevant elsewhere too but I think that with the number of params with similar names, it gets a bit confusing to see what's what. What do you think about this refactor?

Purpose Current Proposed
scVI integration — query --obs_categorical_covariates --scvi_obs_categorical_covariates
scVI integration — query --obs_numerical_covariates --scvi_obs_numerical_covariates
scANVI annotation — query --input_obs_categorical_covariates --scanvi_obs_categorical_covariates
scANVI annotation — query --input_obs_numerical_covariates --scanvi_obs_numerical_covariates
scANVI annotation — reference --reference_obs_categorical_covariates --scanvi_reference_obs_categorical_covariates
scANVI annotation — reference --reference_obs_numerical_covariates --scanvi_reference_obs_numerical_covariates

params.resources_test = "s3://openpipelines-bio/openpipeline_composed/resources_test/"
include { process_integrate_annotate } from params.rootDir + "/target/nextflow/single_cell/process_integrate_annotate/main.nf"
include { assert_h5mu_slots } from params.rootDir + "/target/_test/nextflow/test_workflows/assert_h5mu_slots/main.nf"
params.resources_test = "s3://openpipelines-bio/openpipeline_incubator/resources_test/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional? Shouldn't it point to the composed bucket?

Suggested change
params.resources_test = "s3://openpipelines-bio/openpipeline_incubator/resources_test/"
params.resources_test = "s3://openpipelines-bio/openpipeline_composed/resources_test/"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, leftover from before merge of main :-) updated now

@dorien-er

Copy link
Copy Markdown
Contributor Author

This might be relevant elsewhere too but I think that with the number of params with similar names, it gets a bit confusing to see what's what. What do you think about this refactor?
Purpose Current Proposed
scVI integration — query --obs_categorical_covariates --scvi_obs_categorical_covariates
scVI integration — query --obs_numerical_covariates --scvi_obs_numerical_covariates
scANVI annotation — query --input_obs_categorical_covariates --scanvi_obs_categorical_covariates
scANVI annotation — query --input_obs_numerical_covariates --scanvi_obs_numerical_covariates
scANVI annotation — reference --reference_obs_categorical_covariates --scanvi_reference_obs_categorical_covariates
scANVI annotation — reference --reference_obs_numerical_covariates --scanvi_reference_obs_numerical_covariates

Good catch - pushed a proposed simplification, where only --input_obs_<x>_covariates (and equivalent --reference_obs_<x>_covariates) are surfaced and applied to both scvi and scanvi, rather than having multiple params for the same purpose - in practice it doesn't make sense to pass different covariates to scvi or scanvi anyway

@dorien-er
dorien-er requested a review from jakubmajercik July 14, 2026 07:44
@dorien-er
dorien-er merged commit 537ac45 into main Jul 14, 2026
2 checks passed
@dorien-er
dorien-er deleted the update-aaas-with-parallel-workflows branch July 14, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants