update aaas with parallel workflows - #21
Conversation
jakubmajercik
left a comment
There was a problem hiding this comment.
This might be relevant elsewhere too but I think that with the number of params with similar names, it gets a bit confusing to see what's what. What do you think about this refactor?
| Purpose | Current | Proposed |
|---|---|---|
| scVI integration — query | --obs_categorical_covariates |
--scvi_obs_categorical_covariates |
| scVI integration — query | --obs_numerical_covariates |
--scvi_obs_numerical_covariates |
| scANVI annotation — query | --input_obs_categorical_covariates |
--scanvi_obs_categorical_covariates |
| scANVI annotation — query | --input_obs_numerical_covariates |
--scanvi_obs_numerical_covariates |
| scANVI annotation — reference | --reference_obs_categorical_covariates |
--scanvi_reference_obs_categorical_covariates |
| scANVI annotation — reference | --reference_obs_numerical_covariates |
--scanvi_reference_obs_numerical_covariates |
| params.resources_test = "s3://openpipelines-bio/openpipeline_composed/resources_test/" | ||
| include { process_integrate_annotate } from params.rootDir + "/target/nextflow/single_cell/process_integrate_annotate/main.nf" | ||
| include { assert_h5mu_slots } from params.rootDir + "/target/_test/nextflow/test_workflows/assert_h5mu_slots/main.nf" | ||
| params.resources_test = "s3://openpipelines-bio/openpipeline_incubator/resources_test/" |
There was a problem hiding this comment.
Was this change intentional? Shouldn't it point to the composed bucket?
| params.resources_test = "s3://openpipelines-bio/openpipeline_incubator/resources_test/" | |
| params.resources_test = "s3://openpipelines-bio/openpipeline_composed/resources_test/" |
There was a problem hiding this comment.
no, leftover from before merge of main :-) updated now
Good catch - pushed a proposed simplification, where only |
Uh oh!
There was an error while loading. Please reload this page.