Update test resources - #24
Merged
Merged
Conversation
The build reusable-workflow call passed `github.event_name == 'schedule' || inputs.push_containers` to a boolean input. On a push event `inputs` is empty, so the expression resolved to null and failed workflow-call validation at startup, which is why the build job never ran and integration_test was skipped. Treat push like schedule so the value is always a real boolean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Phase 2 built the docker image with tag 'main_build' whenever the
top-level event was a push, but the push step tags it with the
version input ('integration_build'), so the build/push tags diverged
and the push failed. github.event_name reflects the top-level event,
which is 'push' when integration-test triggers main-build from a
branch push. Guard the 'main_build' tag with !is_workflow_call so a
called build uses the provided target_tag, keeping direct pushes to
main unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jakubmajercik
requested changes
Jul 7, 2026
Comment on lines
67
to
+69
| aws s3 sync \ | ||
| "$OUT" \ | ||
| s3://openpipelines-bio/openpipeline_incubator/resources_test/"$ID" \ | ||
| --exclude "*.yaml" \ | ||
| resources_test/reference_gencodev41_chr1 \ | ||
| s3://openpipelines-bio/openpipeline_composed/resources_test/reference_gencodev41_chr1 \ |
Contributor
There was a problem hiding this comment.
Would it make sense to keep only one copy of a reference or is the idea to keep as much separation as possible? openpipeline_qc also generates it and stores to s3://openpipelines-bio/openpipeline_qc/resources_test/cellranger/ref_gencodev41_chr1
Contributor
Author
There was a problem hiding this comment.
The idea is indeed to keep it as separate as possible, and have each package refer to their own test data bucket. To avoid futures in the issues, if changes are made to a test resources in one package, it becomes nearly impossible to check in a structured way what the impact is in other packages.
Co-authored-by: Jakub Majercik <57993790+jakubmajercik@users.noreply.github.com>
Co-authored-by: Jakub Majercik <57993790+jakubmajercik@users.noreply.github.com>
jakubmajercik
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.