Skip to content

add cosmx ingestion#12

Merged
dorien-er merged 9 commits into
mainfrom
add-cosmx-ingestion
Feb 2, 2026
Merged

add cosmx ingestion#12
dorien-er merged 9 commits into
mainfrom
add-cosmx-ingestion

Conversation

@jakubmajercik

Copy link
Copy Markdown
Contributor

No description provided.

@jakubmajercik jakubmajercik linked an issue Jan 22, 2026 that may be closed by this pull request
3 tasks
@jakubmajercik jakubmajercik marked this pull request as ready for review January 22, 2026 14:31

@dorien-er dorien-er left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports look good to me, but having issues running it after updating OP to v4.0 and siqc to v0.2. An HTML file is being generated, but it looks empty.

Fine to merge when this is resolved

@dorien-er dorien-er left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you still surface the parameters that define which graphs should be included in the CosMx report at the workflow level, so users can always toggle on/off any graph they want?

--obs_area: default Area
--obs_aspect_ratio: default AspectRatio
--obs_dapi_stain: default Mean.DAPI, multiple true
--obs_membrane_stain: default Mean.MembraneStain, multiple true
--obs_panck_stain: None (no default), multiple True
--obs_cd45_stain: None (no default), multiple True
--obs_cd3_stain: None (no default), multiple True

@dorien-er dorien-er left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dorien-er dorien-er merged commit 088ba74 into main Feb 2, 2026
2 checks passed
@dorien-er dorien-er deleted the add-cosmx-ingestion branch February 2, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate reports for CosMx data

2 participants