Encode help-*.txt file contents into C source code #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
force-pushed
the
topic/hdrs
branch
3 times, most recently
from
0307079 to
c7d6a1e
Compare
Encode the show_help text files into memory so that we don't have to find and open text files on-the-fly. This helps with relocation, although not strictly necessary. Biggest advantage is that we can supply show_help output from the very beginning, even if we haven't identified the text file directory. Enable access to the new system by PRRTE via a new API by which PRRTE can register its own in-memory array of help messages. Default to the internal PMIx array if show_help has yet to be initialized. Add a new "INMEMHELP" capability flag so that PRRTE can verify this PMIx version's support. Note that PRRTE will be updated so that the master branch and all release branches beginning with v4.0 can require it to build. Based on open-mpi/ompi#13144. Signed-off-by: Ralph Castain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode the show_help text files into memory so that we don't have to find and open text files on-the-fly. This helps with relocation, although not strictly
necessary. Biggest advantage is that we can supply show_help output from the very beginning, even if
we haven't identified the text file directory.
Enable access to the new system by PRRTE via a new API by which PRRTE can register its own in-memory
array of help messages. Default to the internal
PMIx array if show_help has yet to be initialized.
Add a new "INMEMHELP" capability flag so that PRRTE can verify this PMIx version's support. Note that
PRRTE will be updated so that the master branch and all release branches beginning with v4.0 can require it to build.
Based on open-mpi/ompi#13144.
NOTE: THIS PR WILL FAIL ALL PRRTE TESTS UNTIL PRRTE CAN BE UPDATED - CHICKEN/EGG PROBLEM