Work on enabling PTY operations #2229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a cmd line option to specify the user wants to spawn a PTY - e.g., to run a shell on a remote node. Correct error code returns when pipes don't properly get setup, and add an error log so we can see where that happens. When using PTYs, setup all standard IO file descriptors as pty's. Set their term attributes and window sizes to match those of the user's endpoint (i.e., prterun or prun). Signed-off-by: Ralph Castain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a cmd line option to specify the user
wants to spawn a PTY - e.g., to run a shell on
a remote node. Correct error code returns when pipes
don't properly get setup, and add an error log so we
can see where that happens.
When using PTYs, setup all standard IO file descriptors
as pty's. Set their term attributes and window sizes to
match those of the user's endpoint (i.e., prterun or
prun).