Refactor: Remove redundant address1 formatting logic in import.php#390
Open
DaniNC wants to merge 2 commits into
Open
Refactor: Remove redundant address1 formatting logic in import.php#390DaniNC wants to merge 2 commits into
DaniNC wants to merge 2 commits into
Conversation
- Removed fallback logic that rebuilt address1 from street for US contacts. - Address formatting is now consistently handled in ApiHelper.php. - Prevents duplicated logic and potential address inconsistencies. - Improves clarity and maintainability of the import process. Related to INTGRTNS-231.
jakub-sperczynski
requested changes
Jun 23, 2025
jakub-sperczynski
approved these changes
Jun 25, 2025
jakub-sperczynski
left a comment
jakub-sperczynski
left a comment
Collaborator
There was a problem hiding this comment.
From the PHP side it looks ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to INTGRTNS-231.