Skip to content

Return success on sucessful domain renewal/restore#490

Open
DennisSkov wants to merge 1 commit into
openprovider:masterfrom
DennisSkov:successful-domain-renewals
Open

Return success on sucessful domain renewal/restore#490
DennisSkov wants to merge 1 commit into
openprovider:masterfrom
DennisSkov:successful-domain-renewals

Conversation

@DennisSkov

Copy link
Copy Markdown

When a domain renewal is successful, it's required to return 'success' => true, otherwise WHMCS doesn't send the admin email template "Domain Renewal Successful".

@rawa-inv

Copy link
Copy Markdown

When a domain needs to be restored, it's not done automatically; you have to access OpenProvider. Ideally, there should be a field in WHMCS to enable or disable automatic restoration.

@DennisSkov

Copy link
Copy Markdown
Author

Ideally, there should be a field in WHMCS to enable or disable automatic restoration.

I don't think that's necessary. WHMCS already supports domains in redemption period - and you can even sync the redemption details (days until grace/redemption and price) from the registrar. There's no reason not to restore domains automatically.

If the domain has "Redemption" status in WHMCS, that means an admin setup redemption settings for the TLD.
WHMCS won't put domains into redemption status unless it has been manually configured for the specific TLD - if it hasn't, it's just set to "Expired".
Basically, if both OpenProvider and WHMCS returns that the domain is in redemption, you restore the domain. If the two statuses doesn't match, you throw an exception instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants