INTGRTNS-500-Fix-external-nameserver-ip-resolution-in-createNameserversArray

[avishka-ra]

What this fixes

Closes #525.

createNameserversArray() was attempting to resolve an IP for every nameserver before including it in the request. For external nameservers (Cloudflare, Sectigo, OP's own NS, etc.) this is unnecessary — the OP API only requires a hostname for these. The IP lookup would silently drop any NS it couldn't resolve, causing operations to fail or proceed with an incomplete nameserver set.

What changed

The function now checks whether each NS is a glue record (i.e. the NS hostname is a child of the domain being processed — ns1.abc.com for abc.com) before doing any IP resolution.

• Glue records: IP resolution is still performed — first from params, then searchNsRequest, then gethostbyname(). If no IP can be found, a clear exception is thrown.
• External nameservers: IP lookup is skipped entirely. Only the hostname is sent to the OP API.

Affects domain registration, transfer, and save nameservers — all three call this method.

[Copilot]

Pull request overview

Fixes APITools::createNameserversArray() so that IP resolution is only required for true glue records (NS hostnames that are a child of the domain being processed). External nameservers are now passed to the OpenProvider API with only their hostname, instead of being silently dropped when no IP could be resolved. The change affects domain registration, transfer, and "save nameservers" flows.

Changes:

• Add a glue-record check (str_ends_with against sld.tld) and short-circuit external NS entries to be sent without IP resolution.
• Keep the existing IP-resolution chain (params → searchNsRequest/getNameserverList → gethostbyname) only for glue records, and throw/aggregate clearer errors when resolution fails.
• Update user-facing error messages and replace the $invalidNameServer flag with an $invalidGlueNameServers list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.