Manage dns records directly from whmcs admin dashboard#546
Open
YumeChaan wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds REST-based DNS domain-token generation and integrates a new “Manage DNS Zone” flow so WHMCS admins (and clients via existing hooks) can be redirected into Openprovider’s DNS management panel.
Changes:
- Added REST command mapping +
ApiHelper::getDnsDomainToken()to generate DNS domain tokens via the REST client. - Refactored DNS URL generation helper to use REST domain lookup + token creation (including Sectigo/Openprovider zone-provider selection).
- Added an Admin-area custom button + system route/controller action to redirect admins to DNS management.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/registrars/openprovider/routes/system.php | Adds a new system route for the admin DNS management redirect action. |
| modules/registrars/openprovider/OpenProvider/API/CommandMapping.php | Maps createDomainTokenRequest to the REST DomainTokenApi::createToken endpoint. |
| modules/registrars/openprovider/OpenProvider/API/ApiHelper.php | Introduces getDnsDomainToken() wrapper around the new REST command. |
| modules/registrars/openprovider/openprovider.php | Exposes a new WHMCS admin custom button and handler function. |
| modules/registrars/openprovider/helpers/DNS.php | Refactors DNS redirect URL generation to use REST domain + token flow (non-static, DI-based). |
| modules/registrars/openprovider/Controllers/System/DnsController.php | Adds Admin-area redirect action for “Manage DNS Zone”. |
| modules/registrars/openprovider/Controllers/Hooks/DnsAuthController.php | Updates hook controller to use injected DNS helper (non-static). |
| modules/registrars/openprovider/Controllers/Hooks/ClientAreaPrimarySidebarController.php | Updates client-area sidebar controller to use injected DNS helper (non-static). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…gement URL failures
avishka-ra
approved these changes
May 31, 2026
prasad-fernando-74
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the same changes as #425.
A new PR targeting
masterwas created because the previous PR included Composer-related changes (composer.json,composer.lock, autoload files, and vendor folder updates) that were introduced as part of therest-client-phplibrary upgrade on the old branch.Since
masteris now up to date with the requiredrest-client-phpversion, this new PR includes only the ticket-related changes and excludes those dependency and vendor file updates.Changes: