Limit WHOIS ID fields to supported TLDs #561
Open
YumeChaan wants to merge 7 commits into
Open
Conversation
YumeChaan
commented
Jun 18, 2026
YumeChaan
commented
Collaborator
- Added TLD validation for WHOIS contact ID fields
- Hide ID-related WHOIS fields for unsupported TLDs
- Added TLD-specific label mapping for identification fields
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TLD-based handling for WHOIS identification fields in the client area so ID-related fields are only shown/required for supported TLDs, with TLD-specific label mapping via language keys.
Changes:
- Introduced supported-TLD checks and TLD parsing to decide whether to require or remove WHOIS ID fields on
clientareadomaincontactinfo. - Added TLD-to-language-key mapping for the “Company or Individual ID” label (including special handling for Spanish second-level TLDs).
- Added new English override strings for
it/se/fiCORI labels.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/registrars/openprovider/Controllers/Hooks/ClientAreaFooterController.php | Adds TLD detection + conditional JS to require/rename ID fields for supported TLDs and remove them otherwise. |
| lang/overrides/english.php | Adds missing English translation keys for CORI labels for additional TLDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
avishka-ra
reviewed
Jul 2, 2026
avishka-ra
approved these changes
Jul 3, 2026
prasad-fernando-74
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.