Add parameters for .dk to module config and UI#563
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the bundled Openprovider REST client and extends the WHMCS module’s additional domain fields to support an optional “sole proprietorship” flag for .dk registrations via customerExtensionAdditionalData.
Changes:
- Bump
openprovider/rest-client-phpfromv2.2.1-betatov2.2.2-beta(addssole_proprietorshiptoCustomerExtensionData). - Add a new optional
.dktickbox field mapped tocustomerExtensionAdditionalData(soleProprietorship). - Refresh Composer-generated vendor metadata files after the dependency update.
Reviewed changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/registrars/openprovider/vendor/openprovider/rest-client-php/src/Person/Model/CustomerExtensionData.php | Adds sole_proprietorship property support in the SDK model. |
| modules/registrars/openprovider/configuration/additionalfields.php | Introduces .dk “sole proprietorship” tickbox mapped to customer extension additional data. |
| modules/registrars/openprovider/composer.json | Updates REST client requirement to v2.2.2-beta. |
| modules/registrars/openprovider/composer.lock | Locks updated REST client version and updates Composer metadata. |
| modules/registrars/openprovider/vendor/composer/platform_check.php | Composer-generated change: error handling now throws a RuntimeException. |
| modules/registrars/openprovider/vendor/autoload.php | Composer-generated change: throws RuntimeException on platform issues. |
| modules/registrars/openprovider/vendor/composer/InstalledVersions.php | Composer-generated change: internal handling tweaks for installed package discovery. |
| modules/registrars/openprovider/vendor/composer/installed.php | Composer-generated update of installed package references/versions. |
| modules/registrars/openprovider/vendor/composer/installed.json | Composer-generated update of installed package references/versions. |
| modules/registrars/openprovider/vendor/composer/autoload_static.php | Composer-generated autoload map ordering change. |
| modules/registrars/openprovider/vendor/composer/autoload_psr4.php | Composer-generated PSR-4 map ordering change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
faafa8c to
70c9361
Compare
add user type in lang file Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
prasad-fernando-74
left a comment
There was a problem hiding this comment.
Automated review of the .DK parameters change. Scope looks clean — the vendor/composer churn is a legitimate rest-client-php bump (v2.2.1-beta → v2.2.2-beta) bringing sole_proprietorship on CustomerExtensionData, and preCheckout is correctly wired to the ShoppingCartValidateCheckout hook, so returning ['error' => …] is the right server-side gate.
Five inline notes below. The two "please verify" items (item on the dropdown values, and the sole-proprietorship rule direction) are questions I couldn't confirm from the code alone — everything else is a concrete suggestion.
Fixed indentation. Removed array_values() and use direct indexing.
rest-client-phptov2.2.2-beta, which addssole_proprietorshipto CustomerExtensionData