Skip to content

Add parameters for .dk to module config and UI#563

Open
YumeChaan wants to merge 20 commits into
masterfrom
INTGRTNS-539-WHMCS-Domain-Module-Add-Parameters-for-.DK-to-module-config-and-UI
Open

Add parameters for .dk to module config and UI#563
YumeChaan wants to merge 20 commits into
masterfrom
INTGRTNS-539-WHMCS-Domain-Module-Add-Parameters-for-.DK-to-module-config-and-UI

Conversation

@YumeChaan

Copy link
Copy Markdown
Collaborator
  • Updated rest-client-php to v2.2.2-beta, which adds sole_proprietorship to CustomerExtensionData
  • Added optional soleProprietorship tickbox for .dk registration - sends true/false to the API via customerExtensionAdditionalData

Copilot AI review requested due to automatic review settings June 22, 2026 13:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bundled Openprovider REST client and extends the WHMCS module’s additional domain fields to support an optional “sole proprietorship” flag for .dk registrations via customerExtensionAdditionalData.

Changes:

  • Bump openprovider/rest-client-php from v2.2.1-beta to v2.2.2-beta (adds sole_proprietorship to CustomerExtensionData).
  • Add a new optional .dk tickbox field mapped to customerExtensionAdditionalData (soleProprietorship).
  • Refresh Composer-generated vendor metadata files after the dependency update.

Reviewed changes

Copilot reviewed 2 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
modules/registrars/openprovider/vendor/openprovider/rest-client-php/src/Person/Model/CustomerExtensionData.php Adds sole_proprietorship property support in the SDK model.
modules/registrars/openprovider/configuration/additionalfields.php Introduces .dk “sole proprietorship” tickbox mapped to customer extension additional data.
modules/registrars/openprovider/composer.json Updates REST client requirement to v2.2.2-beta.
modules/registrars/openprovider/composer.lock Locks updated REST client version and updates Composer metadata.
modules/registrars/openprovider/vendor/composer/platform_check.php Composer-generated change: error handling now throws a RuntimeException.
modules/registrars/openprovider/vendor/autoload.php Composer-generated change: throws RuntimeException on platform issues.
modules/registrars/openprovider/vendor/composer/InstalledVersions.php Composer-generated change: internal handling tweaks for installed package discovery.
modules/registrars/openprovider/vendor/composer/installed.php Composer-generated update of installed package references/versions.
modules/registrars/openprovider/vendor/composer/installed.json Composer-generated update of installed package references/versions.
modules/registrars/openprovider/vendor/composer/autoload_static.php Composer-generated autoload map ordering change.
modules/registrars/openprovider/vendor/composer/autoload_psr4.php Composer-generated PSR-4 map ordering change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/registrars/openprovider/configuration/additionalfields.php Outdated
Comment thread modules/registrars/openprovider/configuration/additionalfields.php Outdated
@YumeChaan YumeChaan force-pushed the INTGRTNS-539-WHMCS-Domain-Module-Add-Parameters-for-.DK-to-module-config-and-UI branch from faafa8c to 70c9361 Compare June 22, 2026 14:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 13 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 13 changed files in this pull request and generated 4 comments.

Comment thread lang/overrides/english.php Outdated
Comment thread modules/registrars/openprovider/configuration/additionalfields.php
Comment thread modules/registrars/openprovider/Controllers/Hooks/ShoppingCartController.php Outdated
Comment thread modules/registrars/openprovider/Controllers/Hooks/ShoppingCartController.php Outdated
YumeChaan and others added 3 commits July 13, 2026 13:33
add user type in lang file

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@YumeChaan YumeChaan requested a review from avishka-ra July 13, 2026 08:24

@prasad-fernando-74 prasad-fernando-74 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review of the .DK parameters change. Scope looks clean — the vendor/composer churn is a legitimate rest-client-php bump (v2.2.1-beta → v2.2.2-beta) bringing sole_proprietorship on CustomerExtensionData, and preCheckout is correctly wired to the ShoppingCartValidateCheckout hook, so returning ['error' => …] is the right server-side gate.

Five inline notes below. The two "please verify" items (item on the dropdown values, and the sole-proprietorship rule direction) are questions I couldn't confirm from the code alone — everything else is a concrete suggestion.

Comment thread modules/registrars/openprovider/configuration/additionalfields.php
Comment thread modules/registrars/openprovider/Controllers/Hooks/ShoppingCartController.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants